Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6937ee6 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller
Browse files

drivers/net/a2065.c: Convert release_resource to release_region/release_mem_region 

Request_mem_region should be used with release_mem_region, not
release_resource.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression x,E;
@@
*x = request_mem_region(...)
... when != release_mem_region(x)
    when != x = E
* release_resource(x);
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 88e87be6

drivers/net/a2065.c

+5 −5
Original line number Original line Diff line number Diff line
@@ -711,14 +711,14 @@ static int __devinit a2065_init_one(struct zorro_dev *z, 
		return -EBUSY;

		return -EBUSY;

	r2 = request_mem_region(mem_start, A2065_RAM_SIZE, "RAM");

	r2 = request_mem_region(mem_start, A2065_RAM_SIZE, "RAM");

	if (!r2) {

	if (!r2) {

		release_resource(r1);

		release_mem_region(base_addr, sizeof(struct lance_regs));

		return -EBUSY;

		return -EBUSY;

	}

	}





	dev = alloc_etherdev(sizeof(struct lance_private));

	dev = alloc_etherdev(sizeof(struct lance_private));

	if (dev == NULL) {

	if (dev == NULL) {

		release_resource(r1);

		release_mem_region(base_addr, sizeof(struct lance_regs));

		release_resource(r2);

		release_mem_region(mem_start, A2065_RAM_SIZE);

		return -ENOMEM;

		return -ENOMEM;

	}

	}
@@ -764,8 +764,8 @@ static int __devinit a2065_init_one(struct zorro_dev *z, 




	err = register_netdev(dev);

	err = register_netdev(dev);

	if (err) {

	if (err) {

		release_resource(r1);

		release_mem_region(base_addr, sizeof(struct lance_regs));

		release_resource(r2);

		release_mem_region(mem_start, A2065_RAM_SIZE);

		free_netdev(dev);

		free_netdev(dev);

		return err;

		return err;

	}

	}