Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e5465484 authored by Abhijeet Dharmapurikar's avatar Abhijeet Dharmapurikar Committed by David Collins
Browse files

spmi: pmic-arb: fix missing interrupts 



irq_enable which is called when the device resumes. Note that the
irq_enable is called regardless of whether the interrupt was
marked enabled/disabled in the descriptor or whether it was
masked/unmaked at the controller while resuming.

The current driver unconditionally clears the interrupt in its
irq_enable callback. This is dangerous as any interrupts that
happen right before the resume could be missed.

Remove the irq_enable callback and use mask/unmask instead.

Change-Id: I58695ae0c4905a699003d35498dc36c2a947f3f0
Signed-off-by: default avatarAbhijeet Dharmapurikar <adharmap@codeaurora.org>
parent b9b87446

drivers/spmi/spmi-pmic-arb.c

+0 −12
Original line number Diff line number Diff line
@@ -640,17 +640,6 @@ static void qpnpint_irq_unmask(struct irq_data *d) 
	qpnpint_spmi_write(d, QPNPINT_REG_EN_SET, &data, 1);

}



static void qpnpint_irq_enable(struct irq_data *d)

{

	u8 irq  = d->hwirq >> 8;

	u8 data;



	qpnpint_irq_unmask(d);



	data = BIT(irq);

	qpnpint_spmi_write(d, QPNPINT_REG_LATCHED_CLR, &data, 1);

}



static int qpnpint_irq_set_type(struct irq_data *d, unsigned int flow_type)

{

	struct spmi_pmic_arb_qpnpint_type type;
@@ -699,7 +688,6 @@ static int qpnpint_get_irqchip_state(struct irq_data *d, 


static struct irq_chip pmic_arb_irqchip = {

	.name		= "pmic_arb",

	.irq_enable	= qpnpint_irq_enable,

	.irq_ack	= qpnpint_irq_ack,

	.irq_mask	= qpnpint_irq_mask,

	.irq_unmask	= qpnpint_irq_unmask,