Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4aa68bc authored by Shadab Naseem's avatar Shadab Naseem
Browse files

sysmon-qmi: Fix compilation error while using LLVM 



LLVM compiler gave compilation error for directly
dereferencing completion datatype for conditional check.
"warning: address of 'data->ind_recv.done' will always
evaluate to 'true' [-Wpointer-bool-conversion]"
Use completion API to fix it.

Change-Id: I985212802fe37d4b0ebe1b45e90f52d6213864f7
Signed-off-by: default avatarShadab Naseem <snaseem@codeaurora.org>
parent fc29a3de

drivers/soc/qcom/sysmon-qmi.c

+2 −2
Original line number Diff line number Diff line 
/*

 * Copyright (c) 2014-2018, The Linux Foundation. All rights reserved.

 * Copyright (c) 2014-2019, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -480,7 +480,7 @@ int sysmon_send_shutdown(struct subsys_desc *dest_desc) 
	shutdown_ack_ret = wait_for_shutdown_ack(dest_desc);

	if (shutdown_ack_ret < 0) {

		pr_err("shutdown_ack SMP2P bit for %s not set\n", data->name);

		if (!&data->ind_recv.done) {

		if (!completion_done(&data->ind_recv)) {

			pr_err("QMI shutdown indication not received\n");

			ret = shutdown_ack_ret;

		}