Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e414966b authored by Chuck Lever's avatar Chuck Lever Committed by Trond Myklebust
Browse files

NFS: Remove no-op less-than-zero checks on unsigned variables. 



Introduced by commit 16b374ca "NFSv4.1: pnfs: filelayout: add driver's
LAYOUTGET and GETDEVICEINFO infrastructure" (October 20, 2010).

Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent c6e69666

fs/nfs/nfs4filelayout.c

+3 −4
Original line number Diff line number Diff line
@@ -449,9 +449,8 @@ filelayout_check_layout(struct pnfs_layout_hdr *lo, 


	fl->dsaddr = dsaddr;



	if (fl->first_stripe_index < 0 ||

	    fl->first_stripe_index >= dsaddr->stripe_count) {

		dprintk("%s Bad first_stripe_index %d\n",

	if (fl->first_stripe_index >= dsaddr->stripe_count) {

		dprintk("%s Bad first_stripe_index %u\n",

				__func__, fl->first_stripe_index);

		goto out_put;

	}
@@ -552,7 +551,7 @@ filelayout_decode_layout(struct pnfs_layout_hdr *flo, 


	/* Note that a zero value for num_fh is legal for STRIPE_SPARSE.

	 * Futher checking is done in filelayout_check_layout */

	if (fl->num_fh < 0 || fl->num_fh >

	if (fl->num_fh >

	    max(NFS4_PNFS_MAX_STRIPE_CNT, NFS4_PNFS_MAX_MULTI_CNT))

		goto out_err;