Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e3d7e183 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo Committed by Ingo Molnar
Browse files

perf report: Introduce -n/--show-nr-samples 



[acme@doppio pahole]$ perf report -ns comm,dso,symbol -d /lib64/libc-2.10.1.so -C pahole | head -17
    21.94%      32101  [.] _int_malloc
    20.10%      29402  [.] __GI_strcmp
    16.77%      24533  [.] __tsearch
    12.61%      18450  [.] malloc_consolidate
     6.42%       9394  [.] _int_free
     6.28%       9191  [.] __tfind
     4.56%       6678  [.] __GI___libc_free
     4.46%       6520  [.] _IO_vfprintf_internal
     2.59%       3786  [.] __malloc
     1.17%       1716  [.] __GI_memcpy
[acme@doppio pahole]$

Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <1247325517-12272-5-git-send-email-acme@redhat.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent a25e46c4

tools/perf/Documentation/perf-report.txt

+3 −0
Original line number Diff line number Diff line
@@ -24,6 +24,9 @@ OPTIONS 
--dsos=::

	Only consider symbols in these dsos. CSV that understands

	file://filename entries.

-n

--show-nr-samples

	Show the number of samples for each symbol

-C::

--comms=::

	Only consider symbols in these comms. CSV that understands

tools/perf/builtin-report.c

+18 −0
Original line number Diff line number Diff line
@@ -51,6 +51,7 @@ static int verbose; 
static int		modules;



static int		full_paths;

static int		show_nr_samples;



static unsigned long	page_size;

static unsigned long	mmap_window = 32;
@@ -1024,6 +1025,13 @@ hist_entry__fprintf(FILE *fp, struct hist_entry *self, u64 total_samples) 
	else

		ret = fprintf(fp, field_sep ? "%lld" : "%12lld ", self->count);



	if (show_nr_samples) {

		if (field_sep)

			fprintf(fp, "%c%lld", *field_sep, self->count);

		else

			fprintf(fp, "%11lld", self->count);

	}



	list_for_each_entry(se, &hist_entry__sort_list, list) {

		if (se->elide)

			continue;
@@ -1361,6 +1369,12 @@ static size_t output__fprintf(FILE *fp, u64 total_samples) 
	fprintf(fp, "#\n");



	fprintf(fp, "# Overhead");

	if (show_nr_samples) {

		if (field_sep)

			fprintf(fp, "%cSamples", *field_sep);

		else

			fputs("  Samples  ", fp);

	}

	list_for_each_entry(se, &hist_entry__sort_list, list) {

		if (se->elide)

			continue;
@@ -1388,6 +1402,8 @@ static size_t output__fprintf(FILE *fp, u64 total_samples) 
		goto print_entries;



	fprintf(fp, "# ........");

	if (show_nr_samples)

		fprintf(fp, " ..........");

	list_for_each_entry(se, &hist_entry__sort_list, list) {

		unsigned int i;
@@ -1979,6 +1995,8 @@ static const struct option options[] = { 
	OPT_STRING('k', "vmlinux", &vmlinux, "file", "vmlinux pathname"),

	OPT_BOOLEAN('m', "modules", &modules,

		    "load module symbols - WARNING: use only with -k and LIVE kernel"),

	OPT_BOOLEAN('n', "show-nr-samples", &show_nr_samples,

		    "Show a column with the number of samples"),

	OPT_STRING('s', "sort", &sort_order, "key[,key2...]",

		   "sort by key(s): pid, comm, dso, symbol, parent"),

	OPT_BOOLEAN('P', "full-paths", &full_paths,