Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e36fae38 authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Dave Airlie
Browse files

drm: Warn if mode to umode conversion overflows the destination types 



When converting from a drm_display_mode to drm_mode_modeinfo, print a
warning if the the timings values don't fit into the __u16 datatype.

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 2fcfc75b

drivers/gpu/drm/drm_crtc.c

+7 −0
Original line number Diff line number Diff line
@@ -1002,6 +1002,13 @@ EXPORT_SYMBOL(drm_mode_config_cleanup); 
void drm_crtc_convert_to_umode(struct drm_mode_modeinfo *out,

			       struct drm_display_mode *in)

{

	WARN(in->hdisplay > USHRT_MAX || in->hsync_start > USHRT_MAX ||

	     in->hsync_end > USHRT_MAX || in->htotal > USHRT_MAX ||

	     in->hskew > USHRT_MAX || in->vdisplay > USHRT_MAX ||

	     in->vsync_start > USHRT_MAX || in->vsync_end > USHRT_MAX ||

	     in->vtotal > USHRT_MAX || in->vscan > USHRT_MAX,

	     "timing values too large for mode info\n");



	out->clock = in->clock;

	out->hdisplay = in->hdisplay;

	out->hsync_start = in->hsync_start;