Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e2401654 authored by Salam Noureddine's avatar Salam Noureddine Committed by David S. Miller
Browse files

ipv4 igmp: use in_dev_put in timer handlers instead of __in_dev_put 



It is possible for the timer handlers to run after the call to
ip_mc_down so use in_dev_put instead of __in_dev_put in the handler
function in order to do proper cleanup when the refcnt reaches 0.
Otherwise, the refcnt can reach zero without the in_device being
destroyed and we end up leaking a reference to the net_device and
see messages like the following,

unregister_netdevice: waiting for eth0 to become free. Usage count = 1

Tested on linux-3.4.43.

Signed-off-by: default avatarSalam Noureddine <noureddine@aristanetworks.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 437a3ae1

net/ipv4/igmp.c

+2 −2
Original line number Diff line number Diff line
@@ -736,7 +736,7 @@ static void igmp_gq_timer_expire(unsigned long data) 


	in_dev->mr_gq_running = 0;

	igmpv3_send_report(in_dev, NULL);

	__in_dev_put(in_dev);

	in_dev_put(in_dev);

}



static void igmp_ifc_timer_expire(unsigned long data)
@@ -749,7 +749,7 @@ static void igmp_ifc_timer_expire(unsigned long data) 
		igmp_ifc_start_timer(in_dev,

				     unsolicited_report_interval(in_dev));

	}

	__in_dev_put(in_dev);

	in_dev_put(in_dev);

}



static void igmp_ifc_event(struct in_device *in_dev)