Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e236b954 authored by Ivan Vecera's avatar Ivan Vecera Committed by David S. Miller
Browse files

bna: fix firmware loading on big-endian machines 



Firmware required by bna is stored in appropriate files as sequence
of LE32 integers. After loading by request_firmware() they need to be
byte-swapped on big-endian arches. Without this conversion the NIC
is unusable on big-endian machines.

Cc: Rasesh Mody <rasesh.mody@qlogic.com>
Signed-off-by: default avatarIvan Vecera <ivecera@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 50dce303

drivers/net/ethernet/brocade/bna/cna_fwimg.c

+7 −0
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ cna_read_firmware(struct pci_dev *pdev, u32 **bfi_image, 
			u32 *bfi_image_size, char *fw_name)

{

	const struct firmware *fw;

	u32 n;



	if (request_firmware(&fw, fw_name, &pdev->dev)) {

		pr_alert("Can't locate firmware %s\n", fw_name);
@@ -40,6 +41,12 @@ cna_read_firmware(struct pci_dev *pdev, u32 **bfi_image, 
	*bfi_image_size = fw->size/sizeof(u32);

	bfi_fw = fw;



	/* Convert loaded firmware to host order as it is stored in file

	 * as sequence of LE32 integers.

	 */

	for (n = 0; n < *bfi_image_size; n++)

		le32_to_cpus(*bfi_image + n);



	return *bfi_image;

error:

	return NULL;