Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e16acb50 authored by Eric W. Biederman's avatar Eric W. Biederman Committed by Greg Kroah-Hartman
Browse files

sysfs: sysfs_setattr remove unnecessary permission check. 



inode_change_ok already clears the SGID bit when necessary
so there is no reason for sysfs_setattr to carry code to do
the same, and it is good to kill the extra copy because when
I moved the code last in certain corner cases the code will
look at the wrong gid.

Acked-by: default avatarSerge Hallyn <serue@us.ibm.com>
Acked-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarEric W. Biederman <ebiederm@aristanetworks.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent ca1bab38

fs/sysfs/inode.c

+0 −4
Original line number Diff line number Diff line
@@ -117,10 +117,6 @@ int sysfs_setattr(struct dentry *dentry, struct iattr *iattr) 
		return error;



	iattr->ia_valid &= ~ATTR_SIZE; /* ignore size changes */

	if (iattr->ia_valid & ATTR_MODE) {

		if (!in_group_p(inode->i_gid) && !capable(CAP_FSETID))

			iattr->ia_mode &= ~S_ISGID;

	}



	error = inode_setattr(inode, iattr);

	if (error)