Audit: reorganize struct audit_watch to save 8 bytes
pahole showed that struct audit_watch had two holes:
struct audit_watch {
        atomic_t                   count;                /*     0     4 */
        /* XXX 4 bytes hole, try to pack */
        char *                     path;                 /*     8     8 */
        dev_t                      dev;                  /*    16     4 */
        /* XXX 4 bytes hole, try to pack */
        long unsigned int          ino;                  /*    24     8 */
        struct audit_parent *      parent;               /*    32     8 */
        struct list_head           wlist;                /*    40    16 */
        struct list_head           rules;                /*    56    16 */
        /* --- cacheline 1 boundary (64 bytes) was 8 bytes ago --- */
        /* size: 72, cachelines: 2, members: 7 */
        /* sum members: 64, holes: 2, sum holes: 8 */
        /* last cacheline: 8 bytes */
};      /* definitions: 1 */
by moving dev after count we save 8 bytes,  actually improving cacheline
usage.  There are typically very few of these in the kernel so it won't be
a large savings, but it's a good thing no matter what.
Signed-off-by:  Eric Paris <eparis@redhat.com>
Signed-off-by:
Eric Paris <eparis@redhat.com>
Signed-off-by:  Al Viro <viro@zeniv.linux.org.uk>
Al Viro <viro@zeniv.linux.org.uk>
Loading
Please register or sign in to comment
