Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e05a9e7b authored by Julia Lawall's avatar Julia Lawall Committed by James Bottomley
Browse files

[SCSI] pm8001: drop redundant memset 

The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression e1,e2,e3,e4;
@@

- memset(e1,e2,e3);
  memcpy(e1,e4,e3);
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Acked-by: default avatarJack Wang <jack_wang@usish.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent 1278b11f

drivers/scsi/pm8001/pm8001_hwi.c

+0 −1
Original line number Diff line number Diff line
@@ -4390,7 +4390,6 @@ pm8001_chip_fw_flash_update_req(struct pm8001_hba_info *pm8001_ha, 
				return -ENOMEM;

		}

	}

	memset(buffer, 0, fw_control->len);

	memcpy(buffer, fw_control->buffer, fw_control->len);

	flash_update_info.sgl.addr = cpu_to_le64(phys_addr);

	flash_update_info.sgl.im_len.len = cpu_to_le32(fw_control->len);