Commit e0299908 authored Jul 15, 2016 by Dan Carpenter Committed by Tomi Valkeinen Aug 11, 2016

video: fbdev: pxafb: potential NULL dereference on error



If we "goto out;" then it calls display_timings_release(timings);
Since "timings" is NULL, that's going to oops.  Just return directly.

Fixes: 420a4882 ('video: fbdev: pxafb: initial devicetree conversion')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

parent 53d73a0a

drivers/video/fbdev/pxafb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2125,7 +2125,7 @@ static int of_get_pxafb_display(struct device dev, struct device_node disp,

		timings = of_get_display_timings(disp);
		if (!timings)
		goto out;
		return -EINVAL;

		ret = -ENOMEM;
		info->modes = kmalloc_array(timings->num_timings,