Commit e0242093 authored Nov 07, 2018 by Janusz Krzysztofik Committed by Greg Kroah-Hartman Dec 17, 2018

ARM: OMAP1: ams-delta: Fix possible use of uninitialized field



[ Upstream commit cec83ff1241ec98113a19385ea9e9cfa9aa4125b ]

While playing with initialization order of modem device, it has been
discovered that under some circumstances (early console init, I
believe) its .pm() callback may be called before the
uart_port->private_data pointer is initialized from
plat_serial8250_port->private_data, resulting in NULL pointer
dereference.  Fix it by checking for uninitialized pointer before using
it in modem_pm().

Fixes: aabf3173 ("ARM: OMAP1: ams-delta: update the modem to use regulator API")
Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 2e6ef7e3

arch/arm/mach-omap1/board-ams-delta.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -511,6 +511,9 @@ static void modem_pm(struct uart_port *port, unsigned int state, unsigned old)
		{
		struct modem_private_data *priv = port->private_data;

		if (!priv)
		return;

		if (IS_ERR(priv->regulator))
		return;