Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dff93bb9 authored by Pan Bian's avatar Pan Bian Committed by Greg Kroah-Hartman
Browse files

f2fs: read page index before freeing 



commit 0ea295dd853e0879a9a30ab61f923c26be35b902 upstream.

The function truncate_node frees the page with f2fs_put_page. However,
the page index is read after that. So, the patch reads the index before
freeing the page.

Fixes: bf39c00a ("f2fs: drop obsolete node page when it is truncated")
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Reviewed-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: default avatarSudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f63ee3bb

fs/f2fs/node.c

+3 −1
Original line number Diff line number Diff line
@@ -656,6 +656,7 @@ static void truncate_node(struct dnode_of_data *dn) 
{

	struct f2fs_sb_info *sbi = F2FS_I_SB(dn->inode);

	struct node_info ni;

	pgoff_t index;



	get_node_info(sbi, dn->nid, &ni);

	if (dn->inode->i_blocks == 0) {
@@ -678,10 +679,11 @@ static void truncate_node(struct dnode_of_data *dn) 
	clear_node_page_dirty(dn->node_page);

	set_sbi_flag(sbi, SBI_IS_DIRTY);



	index = dn->node_page->index;

	f2fs_put_page(dn->node_page, 1);



	invalidate_mapping_pages(NODE_MAPPING(sbi),

			dn->node_page->index, dn->node_page->index);

			index, index);



	dn->node_page = NULL;

	trace_f2fs_truncate_node(dn->inode, dn->nid, ni.blk_addr);