Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit decc27b0 authored by Daniel Mack's avatar Daniel Mack Committed by Mark Brown
Browse files

ASoC: core: fix use after free in snd_soc_remove_platform() 



Coverity spotted an use-after-free condition in snd_soc_remove_platform().
Fix this by moving snd_soc_component_cleanup() after the debug print
statement which uses the component's string.

Signed-off-by: default avatarDaniel Mack <daniel@zonque.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
parent 6596aa04

sound/soc/soc-core.c

+2 −2
Original line number Diff line number Diff line
@@ -4315,10 +4315,10 @@ void snd_soc_remove_platform(struct snd_soc_platform *platform) 
	snd_soc_component_del_unlocked(&platform->component);

	mutex_unlock(&client_mutex);



	snd_soc_component_cleanup(&platform->component);



	dev_dbg(platform->dev, "ASoC: Unregistered platform '%s'\n",

		platform->component.name);



	snd_soc_component_cleanup(&platform->component);

}

EXPORT_SYMBOL_GPL(snd_soc_remove_platform);