Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit debae99a authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

ARM: OMAP2+: Fix refcount leak in omap_gic_of_init 



[ Upstream commit 0f83e6b4161617014017a694888dd8743f46f071 ]

The of_find_compatible_node() function returns a node pointer with
refcount incremented, We should use of_node_put() on it when done
Add the missing of_node_put() to release the refcount.

Fixes: fd1c0786 ("ARM: OMAP4: Fix the init code to have OMAP4460 errata available in DT build")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Message-Id: <20220309104302.18398-1-linmq006@gmail.com>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent c6281ad2

arch/arm/mach-omap2/omap4-common.c

+2 −0
Original line number Diff line number Diff line
@@ -342,10 +342,12 @@ void __init omap_gic_of_init(void) 


	np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic");

	gic_dist_base_addr = of_iomap(np, 0);

	of_node_put(np);

	WARN_ON(!gic_dist_base_addr);



	np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-twd-timer");

	twd_base = of_iomap(np, 0);

	of_node_put(np);

	WARN_ON(!twd_base);



skip_errata_init: