Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ddf58468 authored by Paul Zimmerman's avatar Paul Zimmerman Committed by Greg Kroah-Hartman
Browse files

staging: dwc2: fix potential null pointer access 



We were testing hsotg pointer for null after we had already
dereferenced it

Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarPaul Zimmerman <paulz@synopsys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a9b3ea3d

drivers/staging/dwc2/hcd_ddma.c

+5 −5
Original line number Diff line number Diff line
@@ -217,18 +217,18 @@ static void dwc2_update_frame_list(struct dwc2_hsotg *hsotg, struct dwc2_qh *qh, 
	struct dwc2_host_chan *chan;

	u16 i, j, inc;



	if (!qh->channel) {

		dev_err(hsotg->dev, "qh->channel = %p", qh->channel);

	if (!hsotg) {

		pr_err("hsotg = %p", hsotg);

		return;

	}



	if (!hsotg) {

		dev_err(hsotg->dev, "------hsotg = %p", hsotg);

	if (!qh->channel) {

		dev_err(hsotg->dev, "qh->channel = %p", qh->channel);

		return;

	}



	if (!hsotg->frame_list) {

		dev_err(hsotg->dev, "-------hsotg->frame_list = %p",

		dev_err(hsotg->dev, "hsotg->frame_list = %p",

			hsotg->frame_list);

		return;

	}