Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dde5cf39 authored by Andrey Ryabinin's avatar Andrey Ryabinin Committed by Linus Torvalds
Browse files

ubsan: fix tree-wide -Wmaybe-uninitialized false positives 



-fsanitize=* options makes GCC less smart than usual and increase number
of 'maybe-uninitialized' false-positives. So this patch does two things:

 * Add -Wno-maybe-uninitialized to CFLAGS_UBSAN which will disable all
   such warnings for instrumented files.

 * Remove CONFIG_UBSAN_SANITIZE_ALL from all[yes|mod]config builds. So
   the all[yes|mod]config build goes without -fsanitize=* and still with
   -Wmaybe-uninitialized.

Signed-off-by: default avatarAndrey Ryabinin <aryabinin@virtuozzo.com>
Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 21b2f443

lib/Kconfig.ubsan

+5 −0
Original line number Diff line number Diff line
@@ -13,6 +13,11 @@ config UBSAN_SANITIZE_ALL 
	bool "Enable instrumentation for the entire kernel"

	depends on UBSAN

	depends on ARCH_HAS_UBSAN_SANITIZE_ALL



	# We build with -Wno-maybe-uninitilzed, but we still want to

	# use -Wmaybe-uninitilized in allmodconfig builds.

	# So dependsy bellow used to disable this option in allmodconfig

	depends on !COMPILE_TEST

	default y

	help

	  This option activates instrumentation for the entire kernel.

scripts/Makefile.ubsan

+4 −0
Original line number Diff line number Diff line
@@ -14,4 +14,8 @@ ifdef CONFIG_UBSAN 
ifdef CONFIG_UBSAN_ALIGNMENT

      CFLAGS_UBSAN += $(call cc-option, -fsanitize=alignment)

endif



      # -fsanitize=* options makes GCC less smart than usual and

      # increase number of 'maybe-uninitialized false-positives

      CFLAGS_UBSAN += $(call cc-option, -Wno-maybe-uninitialized)

endif