Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ddc43d6d authored by Sylwester Nawrocki's avatar Sylwester Nawrocki Committed by Mauro Carvalho Chehab
Browse files

[media] fimc-lite: Don't use mutex_lock_interruptible() in device release() 



Use uninterruptible mutex_lock in the release() file op to make
sure all resources are properly freed when a process is being
terminated. Returning -ERESTARTSYS has no effect for a terminating
process and this may cause driver resources not to be released.
This patch is required for stable kernels v3.5+.

Reported-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent ba6b372c

drivers/media/platform/s5p-fimc/fimc-lite.c

+1 −2
Original line number Diff line number Diff line
@@ -491,8 +491,7 @@ static int fimc_lite_close(struct file *file) 
	struct fimc_lite *fimc = video_drvdata(file);

	int ret;



	if (mutex_lock_interruptible(&fimc->lock))

		return -ERESTARTSYS;

	mutex_lock(&fimc->lock);



	if (--fimc->ref_count == 0 && fimc->out_path == FIMC_IO_DMA) {

		clear_bit(ST_FLITE_IN_USE, &fimc->state);