Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dda7ae78 authored by Sylwester Nawrocki's avatar Sylwester Nawrocki Committed by Mauro Carvalho Chehab
Browse files

[media] s5p-fimc: dubious one-bit signed bitfields 



> From: Dan Carpenter [mailto:error27@gmail.com]
>
> These are signed so instead of being 1 and 0 as intended they are -1 and
> 0.  It doesn't cause a bug in the current code but Sparse warns about
> it:
>
> drivers/media/video/s5p-fimc/fimc-core.h:226:28:
> 	error: dubious one-bit signed bitfield
>  struct fimc_scaler {
> -	int	scaleup_h:1;
> -	int	scaleup_v:1;
> -	int	copy_mode:1;
> -	int	enabled:1;
> +	unsigned int	scaleup_h:1;
> +	unsigned int	caleup_v:1;
> +	unsigned int	copy_mode:1;
> +	unsigned int	enabled:1;

In general I agree, however this patch would change scaleup_v:1
to caleup_v, so it cannot be applied in current form.
Here is the corrected patch:

Reported-by: default avatarDan Carpenter <error27@gmail.com&lt;>
Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 29adc2c0

drivers/media/video/s5p-fimc/fimc-core.h

+4 −4
Original line number Diff line number Diff line
@@ -222,10 +222,10 @@ struct fimc_effect { 
 * @real_height:	source pixel (height - offset)

 */

struct fimc_scaler {

	int	scaleup_h:1;

	int	scaleup_v:1;

	int	copy_mode:1;

	int	enabled:1;

	unsigned int scaleup_h:1;

	unsigned int scaleup_v:1;

	unsigned int copy_mode:1;

	unsigned int enabled:1;

	u32	hfactor;

	u32	vfactor;

	u32	pre_hratio;