Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dd605423 authored by Bjorn Andersson's avatar Bjorn Andersson Committed by Greg Kroah-Hartman
Browse files

pinctrl: qcom: Don't clear status bit on irq_unmask 



commit a6566710adaa4a7dd5e0d99820ff9c9c30ee5951 upstream.

Clearing the status bit on irq_unmask will discard any pending interrupt
that did arrive after the irq_ack, i.e. while the IRQ handler function
was executing.

Fixes: f365be09 ("pinctrl: Add Qualcomm TLMM driver")
Cc: Stephen Boyd <sboyd@codeaurora.org>
Reported-by: default avatarTimur Tabi <timur@codeaurora.org>
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b82b2f93

drivers/pinctrl/qcom/pinctrl-msm.c

+0 −4
Original line number Diff line number Diff line
@@ -594,10 +594,6 @@ static void msm_gpio_irq_unmask(struct irq_data *d) 


	spin_lock_irqsave(&pctrl->lock, flags);



	val = readl(pctrl->regs + g->intr_status_reg);

	val &= ~BIT(g->intr_status_bit);

	writel(val, pctrl->regs + g->intr_status_reg);



	val = readl(pctrl->regs + g->intr_cfg_reg);

	val |= BIT(g->intr_enable_bit);

	writel(val, pctrl->regs + g->intr_cfg_reg);