Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dce57aef authored by Bhaktipriya Shridhar's avatar Bhaktipriya Shridhar Committed by Greg Kroah-Hartman
Browse files

staging: most: hdm-usb: Use macro DIV_ROUND_UP 



The macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)).
It clarifies the divisor calculations. This occurence was detected using the
coccinelle script:
@@
expression e1;
expression e2;
@@
(
- ((e1) + e2 - 1) / (e2)
+ DIV_ROUND_UP(e1,e2)
|
- ((e1) + (e2 - 1))/ (e2)
+ DIV_ROUND_UP(e1,e2)
)

The macro CEILING was dropped altogether and has been replaced with
DIV_ROUND_UP.

Signed-off-by: default avatarBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3e8b9fe0

drivers/staging/most/hdm-usb/hdm_usb.c

+1 −2
Original line number Diff line number Diff line
@@ -40,7 +40,6 @@ 
#define MAX_SUFFIX_LEN		10

#define MAX_STRING_LEN		80

#define MAX_BUF_SIZE		0xFFFF

#define CEILING(x, y)		(((x) + (y) - 1) / (y))



#define USB_VENDOR_ID_SMSC	0x0424  /* VID: SMSC */

#define USB_DEV_ID_BRDG		0xC001  /* PID: USB Bridge */
@@ -786,7 +785,7 @@ static int hdm_configure_channel(struct most_interface *iface, int channel, 
	temp_size += tail_space;



	/* calculate extra length to comply w/ HW padding */

	conf->extra_len = (CEILING(temp_size, USB_MTU) * USB_MTU)

	conf->extra_len = (DIV_ROUND_UP(temp_size, USB_MTU) * USB_MTU)

			  - conf->buffer_size;

exit:

	mdev->conf[channel] = *conf;