Commit dbcae088 authored Aug 15, 2013 by Dan Carpenter Committed by Sage Weil Aug 27, 2013

libceph: create_singlethread_workqueue() doesn't return ERR_PTRs



create_singlethread_workqueue() returns NULL on error, and it doesn't
return ERR_PTRs.

I tweaked the error handling a little to be consistent with earlier in
the function.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Sage Weil <sage@inktank.com>

parent b72e19b9

net/ceph/osd_client.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -2264,12 +2264,10 @@ int ceph_osdc_init(struct ceph_osd_client osdc, struct ceph_client client)
		if (err < 0)
		goto out_msgpool;

		err = -ENOMEM;
		osdc->notify_wq = create_singlethread_workqueue("ceph-watch-notify");
		if (IS_ERR(osdc->notify_wq)) {
		err = PTR_ERR(osdc->notify_wq);
		osdc->notify_wq = NULL;
		if (!osdc->notify_wq)
		goto out_msgpool;
		}
		return 0;

		out_msgpool: