Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db92ea5d authored by Michael McConville's avatar Michael McConville Committed by David S. Miller
Browse files

dscc4: Undefined signed int shift 

My analysis in the below mail applies, although the second part is
unnecessary because i isn't used in arithmetic operations here:

https://marc.info/?l=openbsd-tech&m=145377854103866&w=2



Thanks for your time.

Signed-off-by: default avatarMichael McConville <mmcco@mykolab.com>
Acked-by: default avatarFrancois Romieu <romieu@fr.zoreil.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 66d9cd0f

drivers/net/wan/dscc4.c

+1 −1
Original line number Diff line number Diff line
@@ -1626,7 +1626,7 @@ static void dscc4_tx_irq(struct dscc4_pci_priv *ppriv, 
		if (state & Xpr) {

			void __iomem *scc_addr;

			unsigned long ring;

			int i;

			unsigned int i;



			/*

			 * - the busy condition happens (sometimes);