Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db59b464 authored by Alan Stern's avatar Alan Stern Committed by Greg Kroah-Hartman
Browse files

uhci-hcd: fix list access bug 



When skipping to the last TD of an URB, go to the _last_ entry in the
list instead of the _first_ entry (as780).  This fixes Bugzilla #6747
and possibly others.

Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 5df3d8b5

drivers/usb/host/uhci-q.c

+1 −1
Original line number Diff line number Diff line
@@ -372,7 +372,7 @@ static void uhci_fixup_toggles(struct uhci_qh *qh, int skip_first) 
		 * need to change any toggles in this URB */

		td = list_entry(urbp->td_list.next, struct uhci_td, list);

		if (toggle > 1 || uhci_toggle(td_token(td)) == toggle) {

			td = list_entry(urbp->td_list.next, struct uhci_td,

			td = list_entry(urbp->td_list.prev, struct uhci_td,

					list);

			toggle = uhci_toggle(td_token(td)) ^ 1;