Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db27ebb1 authored by Sasha Levin's avatar Sasha Levin Committed by David S. Miller
Browse files

net: rds: use correct size for max unacked packets and bytes 



Max unacked packets/bytes is an int while sizeof(long) was used in the
sysctl table.

This means that when they were getting read we'd also leak kernel memory
to userspace along with the timeout values.

Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5201aa49

net/rds/sysctl.c

+2 −2
Original line number Diff line number Diff line
@@ -71,14 +71,14 @@ static struct ctl_table rds_sysctl_rds_table[] = { 
	{

		.procname	= "max_unacked_packets",

		.data		= &rds_sysctl_max_unacked_packets,

		.maxlen         = sizeof(unsigned long),

		.maxlen         = sizeof(int),

		.mode           = 0644,

		.proc_handler   = proc_dointvec,

	},

	{

		.procname	= "max_unacked_bytes",

		.data		= &rds_sysctl_max_unacked_bytes,

		.maxlen         = sizeof(unsigned long),

		.maxlen         = sizeof(int),

		.mode           = 0644,

		.proc_handler   = proc_dointvec,

	},