Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db077278 authored by Greg Rose's avatar Greg Rose Committed by Jeff Kirsher
Browse files

i40e: Remove zero check 



A mirror rule ID may be zero so do not return invalid parameter when the
user passes in a zero value for a rule ID.

Change-ID: I261b8c24725ce2c6ed32f859da81093dfcbe2970
Signed-off-by: default avatarGreg Rose <gregory.v.rose@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent bccf4744

drivers/net/ethernet/intel/i40e/i40e_common.c

+1 −4
Original line number Diff line number Diff line
@@ -2668,10 +2668,7 @@ i40e_status i40e_aq_delete_mirrorrule(struct i40e_hw *hw, u16 sw_seid, 
			u16 *rules_used, u16 *rules_free)

{

	/* Rule ID has to be valid except rule_type: INGRESS VLAN mirroring */

	if (rule_type != I40E_AQC_MIRROR_RULE_TYPE_VLAN) {

		if (!rule_id)

			return I40E_ERR_PARAM;

	} else {

	if (rule_type == I40E_AQC_MIRROR_RULE_TYPE_VLAN) {

		/* count and mr_list shall be valid for rule_type INGRESS VLAN

		 * mirroring. For other rule_type, count and rule_type should

		 * not matter.