Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit da7800a8 authored by Rex Zhu's avatar Rex Zhu Committed by Alex Deucher
Browse files

drm/amd/powerplay: avoid out of bounds access on array ps. 



check array index first and then visit the array.

Signed-off-by: default avatarRex Zhu <Rex.Zhu@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 1da2c326

drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c

+6 −6
Original line number Diff line number Diff line
@@ -2984,19 +2984,19 @@ static int smu7_get_pp_table_entry_callback_func_v0(struct pp_hwmgr *hwmgr, 
	if (!(data->mc_micro_code_feature & DISABLE_MC_LOADMICROCODE) && memory_clock > data->highest_mclk)

		data->highest_mclk = memory_clock;



	performance_level = &(ps->performance_levels

			[ps->performance_level_count++]);



	PP_ASSERT_WITH_CODE(

			(ps->performance_level_count < smum_get_mac_definition(hwmgr->smumgr, SMU_MAX_LEVELS_GRAPHICS)),

			"Performance levels exceeds SMC limit!",

			return -EINVAL);



	PP_ASSERT_WITH_CODE(

			(ps->performance_level_count <=

			(ps->performance_level_count <

					hwmgr->platform_descriptor.hardwareActivityPerformanceLevels),

			"Performance levels exceeds Driver limit!",

			return -EINVAL);

			"Performance levels exceeds Driver limit, Skip!",

			return 0);



	performance_level = &(ps->performance_levels

			[ps->performance_level_count++]);



	/* Performance levels are arranged from low to high. */

	performance_level->memory_clock = memory_clock;