Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit da6163ad authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: versatile: Simplify host bridge window iteration 



The switch is the only statement in the resource_list_for_each_entry()
loop, so remove unnecessary "continue" statements in the switch.  Simplify
checking for the required non-prefetchable memory aperture.

No functional change intended.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 2fbb3530

drivers/pci/host/pci-versatile.c

+5 −12
Original line number Diff line number Diff line
@@ -90,11 +90,9 @@ static int versatile_pci_parse_request_of_pci_ranges(struct device *dev, 
		switch (resource_type(res)) {

		case IORESOURCE_IO:

			err = pci_remap_iospace(res, iobase);

			if (err) {

			if (err)

				dev_warn(dev, "error %d: failed to map resource %pR\n",

					 err, res);

				continue;

			}

			break;

		case IORESOURCE_MEM:

			res_valid |= !(res->flags & IORESOURCE_PREFETCH);
@@ -104,19 +102,14 @@ static int versatile_pci_parse_request_of_pci_ranges(struct device *dev, 
			mem++;



			break;

		case IORESOURCE_BUS:

		default:

			continue;

		}

	}



	if (!res_valid) {

	if (res_valid)

		return 0;



	dev_err(dev, "non-prefetchable memory resource required\n");

	err = -EINVAL;

		goto out_release_res;

	}



	return 0;



out_release_res:

	pci_free_resource_list(res);