Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9efd2af authored by Sarveshwar Bandi's avatar Sarveshwar Bandi Committed by David S. Miller
Browse files

be2net: Fix to avoid firmware update when interface is not open. 



Since interrupts are enabled only when open is called on the interface,
Attempting a firmware update operation when interface is down could lead to
partial success or failure of operation. This fix fails the request if
netif_running is false.

Signed-off-by: default avatarSarveshwar Bandi <Sarveshwar.Bandi@emulex.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent dba4490d

drivers/net/benet/be_main.c

+6 −0
Original line number Diff line number Diff line
@@ -2458,6 +2458,12 @@ int be_load_fw(struct be_adapter *adapter, u8 *func) 
	int status, i = 0, num_imgs = 0;

	const u8 *p;



	if (!netif_running(adapter->netdev)) {

		dev_err(&adapter->pdev->dev,

			"Firmware load not allowed (interface is down)\n");

		return -EPERM;

	}



	strcpy(fw_file, func);



	status = request_firmware(&fw, fw_file, &adapter->pdev->dev);