Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9e6620c authored by Markus Elfring's avatar Markus Elfring Committed by David S. Miller
Browse files

ATM-ENI: Use kmalloc_array() in eni_start() 



* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fa5f4aaf

drivers/atm/eni.c

+3 −2
Original line number Diff line number Diff line
@@ -1845,8 +1845,9 @@ static int eni_start(struct atm_dev *dev) 
	/* initialize memory management */

	buffer_mem = eni_dev->mem - (buf - eni_dev->ram);

	eni_dev->free_list_size = buffer_mem/MID_MIN_BUF_SIZE/2;

	eni_dev->free_list = kmalloc(

	    sizeof(struct eni_free)*(eni_dev->free_list_size+1),GFP_KERNEL);

	eni_dev->free_list = kmalloc_array(eni_dev->free_list_size + 1,

					   sizeof(*eni_dev->free_list),

					   GFP_KERNEL);

	if (!eni_dev->free_list) {

		printk(KERN_ERR DEV_LABEL "(itf %d): couldn't get free page\n",

		    dev->number);