Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9590143 authored by NeilBrown's avatar NeilBrown
Browse files

md/bitmap: fix a might_sleep() warning. 



commit 8eb23b9f
    sched: Debug nested sleeps

causes false-positive warnings in RAID5 code.

This annotation removes them and adds a comment
explaining why there is no real problem.

Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent b1b02fe9

drivers/md/bitmap.c

+13 −0
Original line number Diff line number Diff line
@@ -72,6 +72,19 @@ __acquires(bitmap->lock) 
	/* this page has not been allocated yet */



	spin_unlock_irq(&bitmap->lock);

	/* It is possible that this is being called inside a

	 * prepare_to_wait/finish_wait loop from raid5c:make_request().

	 * In general it is not permitted to sleep in that context as it

	 * can cause the loop to spin freely.

	 * That doesn't apply here as we can only reach this point

	 * once with any loop.

	 * When this function completes, either bp[page].map or

	 * bp[page].hijacked.  In either case, this function will

	 * abort before getting to this point again.  So there is

	 * no risk of a free-spin, and so it is safe to assert

	 * that sleeping here is allowed.

	 */

	sched_annotate_sleep();

	mappage = kzalloc(PAGE_SIZE, GFP_NOIO);

	spin_lock_irq(&bitmap->lock);