Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d8d6aedd authored by Liam Breck's avatar Liam Breck Committed by Greg Kroah-Hartman
Browse files

power: supply: bq24190_charger: Fix irq trigger to IRQF_TRIGGER_FALLING 



commit 767eee362fd72bb2ca44cc80419ca4b38c6d8369 upstream.

The interrupt signal is TRIGGER_FALLING. This is is specified in the
data sheet PIN FUNCTIONS: "The INT pin sends active low, 256us
pulse to host to report charger device status and fault."

Also the direction can be seen in the data sheet Figure 37 "BQ24190
with D+/D- Detection and USB On-The-Go (OTG)" which shows a 10k
pull-up resistor installed for the sample configurations.

Fixes: d7bf353f ("bq24190_charger: Add support for TI BQ24190 Battery Charger")
Signed-off-by: default avatarLiam Breck <kernel@networkimprov.net>
Acked-by: default avatarMark Greer <mgreer@animalcreek.com>
Acked-by: default avatarTony Lindgren <tony@atomide.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 89e8bd3a

drivers/power/supply/bq24190_charger.c

+1 −1
Original line number Diff line number Diff line
@@ -1394,7 +1394,7 @@ static int bq24190_probe(struct i2c_client *client, 


	ret = devm_request_threaded_irq(dev, bdi->irq, NULL,

			bq24190_irq_handler_thread,

			IRQF_TRIGGER_RISING | IRQF_ONESHOT,

			IRQF_TRIGGER_FALLING | IRQF_ONESHOT,

			"bq24190-charger", bdi);

	if (ret < 0) {

		dev_err(dev, "Can't set up irq handler\n");