Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d865177a authored by Liu Bo's avatar Liu Bo Committed by David Sterba
Browse files

Btrfs: clear uptodate flags of pages in sys_array eb 



We set uptodate flag to pages in the temporary sys_array eb,
but do not clear the flag after free eb.  As the special
btree inode may still hold a reference on those pages, the
uptodate flag can remain alive in them.

If btrfs_super_chunk_root has been intentionally changed to the
offset of this sys_array eb, reading chunk_root will read content
of sys_array and it will skip our beautiful checks in
btree_readpage_end_io_hook() because of
"pages of eb are uptodate => eb is uptodate"

This adds the 'clear uptodate' part to force it to read from disk.

Reviewed-by: default avatarJosef Bacik <jbacik@fb.com>
Signed-off-by: default avatarLiu Bo <bo.li.liu@oracle.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 65d4f4c1

fs/btrfs/volumes.c

+2 −0
Original line number Diff line number Diff line
@@ -6631,12 +6631,14 @@ int btrfs_read_sys_array(struct btrfs_root *root) 
		sb_array_offset += len;

		cur_offset += len;

	}

	clear_extent_buffer_uptodate(sb);

	free_extent_buffer_stale(sb);

	return ret;



out_short_read:

	printk(KERN_ERR "BTRFS: sys_array too short to read %u bytes at offset %u\n",

			len, cur_offset);

	clear_extent_buffer_uptodate(sb);

	free_extent_buffer_stale(sb);

	return -EIO;

}