Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7f08452 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: keyspan_pda: remove bogus disconnect test from dtr_rts 



Remove bogus (and unnecessary) test for serial->dev being NULL in
dtr_rts.

The device is never cleared, and disconnect is handled for dtr_rts in
usb-serial core anyway.

Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 80dfe0ce

drivers/usb/serial/keyspan_pda.c

+4 −6
Original line number Original line Diff line number Diff line
@@ -595,13 +595,11 @@ static void keyspan_pda_dtr_rts(struct usb_serial_port *port, int on) 
{

{

	struct usb_serial *serial = port->serial;

	struct usb_serial *serial = port->serial;





	if (serial->dev) {

	if (on)

	if (on)

		keyspan_pda_set_modem_info(serial, (1 << 7) | (1 << 2));

		keyspan_pda_set_modem_info(serial, (1 << 7) | (1 << 2));

	else

	else

		keyspan_pda_set_modem_info(serial, 0);

		keyspan_pda_set_modem_info(serial, 0);

}

}

}









static int keyspan_pda_open(struct tty_struct *tty,

static int keyspan_pda_open(struct tty_struct *tty,