Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6fb56db authored by Xiaoyu Ye's avatar Xiaoyu Ye Committed by Gerrit - the friendly Code Review server
Browse files

drivers: soc: qcom: Add error handling in function avtimer_ioctl 



Error handling is added to prevent garbage value being passed to
user space by the uninitialized local variable avtimer_tick.

CRs-Fixed: 1097878
Change-Id: I3f895deaae3acf329088cf8135859cc41e781763
Signed-off-by: default avatarXiaoyu Ye <benyxy@codeaurora.org>
parent 282e28df

drivers/soc/qcom/avtimer.c

+10 −2
Original line number Diff line number Diff line
@@ -332,9 +332,17 @@ static long avtimer_ioctl(struct file *file, unsigned int ioctl_num, 
	switch (ioctl_num) {

	case IOCTL_GET_AVTIMER_TICK:

	{

		uint64_t avtimer_tick;

		uint64_t avtimer_tick = 0;

		int rc;



		rc = avcs_core_query_timer(&avtimer_tick);



		if (rc) {

			pr_err("%s: Error: Invalid AV Timer tick, rc = %d\n",

				__func__, rc);

			return rc;

		}



		avcs_core_query_timer(&avtimer_tick);

		pr_debug_ratelimited("%s: AV Timer tick: time %llx\n",

		__func__, avtimer_tick);

		if (copy_to_user((void *) ioctl_param, &avtimer_tick,