Commit d6daef95 authored Nov 07, 2013 by Dan Carpenter Committed by Lee Jones Nov 11, 2013

mfd: pm8921: Potential NULL dereference in pm8921_remove()



We assume that "pmic" could be NULL and then dereference it two lines
later.  I fix this by moving the dereference inside the NULL check.

Fixes: c013f0a5 ('mfd: Add pm8xxx irq support')

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

parent 0b208e41

drivers/mfd/pm8921-core.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -171,12 +171,13 @@ static int pm8921_remove(struct platform_device *pdev)
		drvdata = platform_get_drvdata(pdev);
		if (drvdata)
		pmic = drvdata->pm_chip_data;
		if (pmic)
		if (pmic) {
		mfd_remove_devices(pmic->dev);
		if (pmic->irq_chip) {
		pm8xxx_irq_exit(pmic->irq_chip);
		pmic->irq_chip = NULL;
		}
		}

		return 0;
		}