Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6dab7dd authored by Jean Delvare's avatar Jean Delvare Committed by Jean Delvare
Browse files

hwmon: Fix PCI device reference leak in quirk 



Thankfully this only affects systems with one specific south bridge
and is most probably harmless unless the hwmon module is heavily
cycled.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Acked-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 752451f0

drivers/hwmon/hwmon.c

+14 −12
Original line number Diff line number Diff line
@@ -84,10 +84,9 @@ static void __init hwmon_pci_quirks(void) 


	/* Open access to 0x295-0x296 on MSI MS-7031 */

	sb = pci_get_device(PCI_VENDOR_ID_ATI, 0x436c, NULL);

	if (sb &&

	    (sb->subsystem_vendor == 0x1462 &&	/* MSI */

	     sb->subsystem_device == 0x0031)) {	/* MS-7031 */



	if (sb) {

		if (sb->subsystem_vendor == 0x1462 &&	/* MSI */

		    sb->subsystem_device == 0x0031) {	/* MS-7031 */

			pci_read_config_byte(sb, 0x48, &enable);

			pci_read_config_word(sb, 0x64, &base);
@@ -95,8 +94,11 @@ static void __init hwmon_pci_quirks(void) 
				dev_info(&sb->dev,

					 "Opening wide generic port at 0x295\n");

				pci_write_config_word(sb, 0x64, 0x295);

			pci_write_config_byte(sb, 0x48, enable | BIT(2));

				pci_write_config_byte(sb, 0x48,

						      enable | BIT(2));

			}

		}

		pci_dev_put(sb);

	}

#endif

}