Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6701d25 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

PowerCap: Fix an error code in powercap_register_zone() 




[ Upstream commit 216c4e9db4c9d1d2a382b42880442dc632cd47d9 ]

In the current code we accidentally return the successful result from
idr_alloc() instead of a negative error pointer.  The caller is looking
for an error pointer and so it treats the returned value as a valid
pointer.

This one might be a bit serious because if it lets people get around the
kernel's protection for remapping NULL.  I'm not sure.

Fixes: 75d2364e (PowerCap: Add class driver)
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 69df2501

drivers/powercap/powercap_sys.c

+1 −0
Original line number Diff line number Diff line
@@ -538,6 +538,7 @@ struct powercap_zone *powercap_register_zone( 


	power_zone->id = result;

	idr_init(&power_zone->idr);

	result = -ENOMEM;

	power_zone->name = kstrdup(name, GFP_KERNEL);

	if (!power_zone->name)

		goto err_name_alloc;