Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6250a03 authored by Alan Cox's avatar Alan Cox Committed by Jeff Garzik
Browse files

pata_ali: Fix regression with old devices 



Making the new stuff work broke some of the old chipsets. We need to go
back to the old set up values for these it seems. Unfortunately even with
documentation this is basically a mix of cargoculting and guesswork.

Chased down to the exact line by Gianluca.

Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent be315d46

drivers/ata/pata_ali.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -453,7 +453,9 @@ static void ali_init_chipset(struct pci_dev *pdev) 
			/* Clear CD-ROM DMA write bit */

			/* Clear CD-ROM DMA write bit */

			tmp &= 0x7F;

			tmp &= 0x7F;

		/* Cable and UDMA */

		/* Cable and UDMA */

		pci_write_config_byte(pdev, 0x4B, tmp | 0x09);

		if (pdev->revision >= 0xc2)

			tmp |= 0x01;

		pci_write_config_byte(pdev, 0x4B, tmp | 0x08);

		/*

		/*

		 * CD_ROM DMA on (0x53 bit 0). Enable this even if we want

		 * CD_ROM DMA on (0x53 bit 0). Enable this even if we want

		 * to use PIO. 0x53 bit 1 (rev 20 only) - enable FIFO control

		 * to use PIO. 0x53 bit 1 (rev 20 only) - enable FIFO control