Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d52b3815 authored by James Bottomley's avatar James Bottomley
Browse files

[SCSI] add missing transport configure points for target and host 



While trying to convert the SPI transport class to attribute groups, I
discovered that we don't actually have any transport configure points
for either the target or the host.  This patch adds these missing
transport class triggers.  The host one is simply done after the add,
the target one tries to be more clever and add it after devices may have
been placed on the target (so the device configure will have set up the
target parameters).

Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent fd110971

drivers/scsi/scsi_scan.c

+2 −0
Original line number Diff line number Diff line
@@ -1489,6 +1489,7 @@ struct scsi_device *__scsi_add_device(struct Scsi_Host *shost, uint channel, 
	if (scsi_host_scan_allowed(shost))

		scsi_probe_and_add_lun(starget, lun, NULL, &sdev, 1, hostdata);

	mutex_unlock(&shost->scan_mutex);

	transport_configure_device(&starget->dev);

	scsi_target_reap(starget);

	put_device(&starget->dev);
@@ -1569,6 +1570,7 @@ static void __scsi_scan_target(struct device *parent, unsigned int channel, 
 out_reap:

	/* now determine if the target has any children at all

	 * and if not, nuke it */

	transport_configure_device(&starget->dev);

	scsi_target_reap(starget);



	put_device(&starget->dev);

drivers/scsi/scsi_sysfs.c

+1 −0
Original line number Diff line number Diff line
@@ -1018,6 +1018,7 @@ int scsi_sysfs_add_host(struct Scsi_Host *shost) 
	}



	transport_register_device(&shost->shost_gendev);

	transport_configure_device(&shost->shost_gendev);

	return 0;

}