Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d4e935bd authored by J. Bruce Fields's avatar J. Bruce Fields Committed by Trond Myklebust
Browse files

The rpc server does not require that service threads take the BKL. 



Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 96f287b0

fs/nfs/callback.c

+0 −12
Original line number Diff line number Diff line
@@ -78,11 +78,6 @@ nfs4_callback_svc(void *vrqstp) 


	set_freezable();



	/*

	 * FIXME: do we really need to run this under the BKL? If so, please

	 * add a comment about what it's intended to protect.

	 */

	lock_kernel();

	while (!kthread_should_stop()) {

		/*

		 * Listen for a request on the socket
@@ -104,7 +99,6 @@ nfs4_callback_svc(void *vrqstp) 
		preverr = err;

		svc_process(rqstp);

	}

	unlock_kernel();

	return 0;

}
@@ -160,11 +154,6 @@ nfs41_callback_svc(void *vrqstp) 


	set_freezable();



	/*

	 * FIXME: do we really need to run this under the BKL? If so, please

	 * add a comment about what it's intended to protect.

	 */

	lock_kernel();

	while (!kthread_should_stop()) {

		prepare_to_wait(&serv->sv_cb_waitq, &wq, TASK_INTERRUPTIBLE);

		spin_lock_bh(&serv->sv_cb_lock);
@@ -183,7 +172,6 @@ nfs41_callback_svc(void *vrqstp) 
		}

		finish_wait(&serv->sv_cb_waitq, &wq);

	}

	unlock_kernel();

	return 0;

}