Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d44a9fe2 authored Jan 07, 2011 by Jeff Layton Committed by Steve French Jan 09, 2011

cifs: switch cifs_open and cifs_create to use CIFSSMBUnixSetFileInfo



We call CIFSSMBUnixSetPathInfo in these functions, but we have a
filehandle since an open was just done. Switch these functions to
use CIFSSMBUnixSetFileInfo instead.

In practice, these codepaths are only used if posix opens are broken.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

parent ca40b714

fs/cifs/dir.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -293,10 +293,8 @@ cifs_create(struct inode inode, struct dentry direntry, int mode,
		args.uid = NO_CHANGE_64;
		args.gid = NO_CHANGE_64;
		}
		CIFSSMBUnixSetPathInfo(xid, tcon, full_path, &args,
		cifs_sb->local_nls,
		cifs_sb->mnt_cifs_flags &
		CIFS_MOUNT_MAP_SPECIAL_CHR);
		CIFSSMBUnixSetFileInfo(xid, tcon, &args, fileHandle,
		current->tgid);
		} else {
		/* BB implement mode setting via Windows security
		descriptors e.g. */

fs/cifs/file.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -424,10 +424,8 @@ int cifs_open(struct inode inode, struct file file)
		.mtime = NO_CHANGE_64,
		.device = 0,
		};
		CIFSSMBUnixSetPathInfo(xid, tcon, full_path, &args,
		cifs_sb->local_nls,
		cifs_sb->mnt_cifs_flags &
		CIFS_MOUNT_MAP_SPECIAL_CHR);
		CIFSSMBUnixSetFileInfo(xid, tcon, &args, netfid,
		pCifsFile->pid);
		}

		out: