Commit d3b0e306 authored Dec 21, 2018 by Dan Carpenter Committed by Greg Kroah-Hartman Mar 05, 2019

usb: gadget: Potential NULL dereference on allocation error



[ Upstream commit df28169e1538e4a8bcd8b779b043e5aa6524545c ]

The source_sink_alloc_func() function is supposed to return error
pointers on error.  The function is called from usb_get_function() which
doesn't check for NULL returns so it would result in an Oops.

Of course, in the current kernel, small allocations always succeed so
this doesn't affect runtime.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 38152b62

drivers/usb/gadget/function/f_sourcesink.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -842,7 +842,7 @@ static struct usb_function *source_sink_alloc_func(

		ss = kzalloc(sizeof(*ss), GFP_KERNEL);
		if (!ss)
		return NULL;
		return ERR_PTR(-ENOMEM);

		ss_opts = container_of(fi, struct f_ss_opts, func_inst);