Commit d3383aaa authored Jan 08, 2015 by Colin Ian King Committed by Michael Ellerman Jan 22, 2015

cxl: remove redundant increment of hwirq



hwirq has not been initialized, however it is being incremented
and also not being referenced in a loop.  This error was detected with
cppcheck:

[drivers/misc/cxl/irq.c:439]: (error) Uninitialized variable: hwirq

Commit 80fa93fc ("cxl: Name interrupts in /proc/interrupt")
introduced this error.

This is a simple fix that removes the redundant increment.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-By: Ian Munsie <imunsie@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent d83fb87b

drivers/misc/cxl/irq.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -436,7 +436,7 @@ int afu_register_irqs(struct cxl_context *ctx, u32 count)
		*/
		INIT_LIST_HEAD(&ctx->irq_names);
		for (r = 1; r < CXL_IRQ_RANGES; r++) {
		for (i = 0; i < ctx->irqs.range[r]; hwirq++, i++) {
		for (i = 0; i < ctx->irqs.range[r]; i++) {
		irq_name = kmalloc(sizeof(struct cxl_irq_name),
		GFP_KERNEL);
		if (!irq_name)