Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d2b7428e authored by Marek Szyprowski's avatar Marek Szyprowski
Browse files

common: dma-mapping: introduce dma_get_sgtable() function 



This patch adds dma_get_sgtable() function which is required to let
drivers to share the buffers allocated by DMA-mapping subsystem. Right
now the driver gets a dma address of the allocated buffer and the kernel
virtual mapping for it. If it wants to share it with other device (= map
into its dma address space) it usually hacks around kernel virtual
addresses to get pointers to pages or assumes that both devices share
the DMA address space. Both solutions are just hacks for the special
cases, which should be avoided in the final version of buffer sharing.

To solve this issue in a generic way, a new call to DMA mapping has been
introduced - dma_get_sgtable(). It allocates a scatter-list which
describes the allocated buffer and lets the driver(s) to use it with
other device(s) by calling dma_map_sg() on it.

This patch provides a generic implementation based on virt_to_page()
call. Architectures which require more sophisticated translation might
provide their own get_sgtable() methods.

Signed-off-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 955c757e

drivers/base/dma-mapping.c

+18 −0
Original line number Diff line number Diff line
@@ -218,6 +218,24 @@ void dmam_release_declared_memory(struct device *dev) 
}

EXPORT_SYMBOL(dmam_release_declared_memory);



/*

 * Create scatter-list for the already allocated DMA buffer.

 */

int dma_common_get_sgtable(struct device *dev, struct sg_table *sgt,

		 void *cpu_addr, dma_addr_t handle, size_t size)

{

	struct page *page = virt_to_page(cpu_addr);

	int ret;



	ret = sg_alloc_table(sgt, 1, GFP_KERNEL);

	if (unlikely(ret))

		return ret;



	sg_set_page(sgt->sgl, page, PAGE_ALIGN(size), 0);

	return 0;

}

EXPORT_SYMBOL(dma_common_get_sgtable);



#endif



/*

include/asm-generic/dma-mapping-common.h

+18 −0
Original line number Diff line number Diff line
@@ -213,4 +213,22 @@ static inline int dma_mmap_writecombine(struct device *dev, struct vm_area_struc 
	return dma_mmap_attrs(dev, vma, cpu_addr, dma_addr, size, &attrs);

}



int

dma_common_get_sgtable(struct device *dev, struct sg_table *sgt,

		       void *cpu_addr, dma_addr_t dma_addr, size_t size);



static inline int

dma_get_sgtable_attrs(struct device *dev, struct sg_table *sgt, void *cpu_addr,

		      dma_addr_t dma_addr, size_t size, struct dma_attrs *attrs)

{

	struct dma_map_ops *ops = get_dma_ops(dev);

	BUG_ON(!ops);

	if (ops->get_sgtable)

		return ops->get_sgtable(dev, sgt, cpu_addr, dma_addr, size,

					attrs);

	return dma_common_get_sgtable(dev, sgt, cpu_addr, dma_addr, size);

}



#define dma_get_sgtable(d, t, v, h, s) dma_get_sgtable_attrs(d, t, v, h, s, NULL)



#endif

include/linux/dma-mapping.h

+3 −0
Original line number Diff line number Diff line
@@ -18,6 +18,9 @@ struct dma_map_ops { 
	int (*mmap)(struct device *, struct vm_area_struct *,

			  void *, dma_addr_t, size_t, struct dma_attrs *attrs);



	int (*get_sgtable)(struct device *dev, struct sg_table *sgt, void *,

			   dma_addr_t, size_t, struct dma_attrs *attrs);



	dma_addr_t (*map_page)(struct device *dev, struct page *page,

			       unsigned long offset, size_t size,

			       enum dma_data_direction dir,