Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d2a5128f authored by Rob Herring's avatar Rob Herring Committed by David S. Miller
Browse files

net: calxedaxgmac: remove some unused statistic counters 



rx_sa_filter_fail and tx_undeflow events are unused and impossible
to occur based on how the h/w is used. We never filter on source MAC
address and TX store and forward mode prevents underflow events.

Reported-by: default avatarLennert Buytenhek <buytenh@wantstofly.org>
Signed-off-by: default avatarRob Herring <rob.herring@calxeda.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2ee68f62

drivers/net/ethernet/calxeda/xgmac.c

+0 −3
Original line number Diff line number Diff line
@@ -353,11 +353,9 @@ struct xgmac_extra_stats { 
	/* Receive errors */

	unsigned long rx_watchdog;

	unsigned long rx_da_filter_fail;

	unsigned long rx_sa_filter_fail;

	unsigned long rx_payload_error;

	unsigned long rx_ip_header_error;

	/* Tx/Rx IRQ errors */

	unsigned long tx_undeflow;

	unsigned long tx_process_stopped;

	unsigned long rx_buf_unav;

	unsigned long rx_process_stopped;
@@ -1581,7 +1579,6 @@ static const struct xgmac_stats xgmac_gstrings_stats[] = { 
	XGMAC_STAT(rx_payload_error),

	XGMAC_STAT(rx_ip_header_error),

	XGMAC_STAT(rx_da_filter_fail),

	XGMAC_STAT(rx_sa_filter_fail),

	XGMAC_STAT(fatal_bus_error),

	XGMAC_HW_STAT(rx_watchdog, XGMAC_MMC_RXWATCHDOG),

	XGMAC_HW_STAT(tx_vlan, XGMAC_MMC_TXVLANFRAME),