Commit d1c14370 authored Jul 10, 2014 by Olof Johansson

platform/chrome: pstore: fix dmi table to match all chrome systems



Turns out that DMI_SYSTEM_VENDOR is actually the native vendor of each
Chromebook/box. I tested the original patch on a Pixel that -- surprise,
has Google as vendor. *facepalm*.

The only other data I can think of to probe on is Google_* in the version
string.  Checking with our firmware team, all systems should have this
and nothing else than Chrome hardware should have the coreboot + Google_*
combination to date.

So, we'll switch to this. For future platforms we are going to move to
using an ACPI device to configure this instead of a DMI table (yay!),
so longer-term that will sort itself out.

Signed-off-by: Olof Johansson <olof@lixom.net>
Reviewed-by: Benson Leung <bleung@chromium.org>

parent 49c68a21

drivers/platform/chrome/chromeos_pstore.c

+2 −12

Original line number	Diff line number	Diff line
		@@ -16,23 +16,13 @@
		static struct dmi_system_id chromeos_pstore_dmi_table[] __initdata = {
		{
		/*
		* Today all Chromebooks/boxes ship with GOOGLE as vendor and
		* Today all Chromebooks/boxes ship with Google_* as version and
		* coreboot as bios vendor. No other systems with this
		* combination are known to date.
		*/
		.matches = {
		DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
		DMI_MATCH(DMI_BIOS_VENDOR, "coreboot"),
		},
		},
		{
		/*
		* The first Samsung Chromebox and Chromebook Series 5 550 use
		* coreboot but with Samsung as the system vendor.
		*/
		.matches = {
		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG"),
		DMI_MATCH(DMI_BIOS_VENDOR, "coreboot"),
		DMI_MATCH(DMI_BIOS_VERSION, "Google_"),
		},
		},
		{