Commit d1a35ee2 authored May 13, 2014 by Emil Tantilov Committed by Jeff Kirsher May 26, 2014

ixgbe: fix linking at 100Mbps on copper devices with MNG FW enabled



Driver was calling setup_link to make sure that fiber interfaces with MNG FW
enabled will get link on probe because the laser was most likely turned off.
This prevented non-fiber devices with MNG FW from linking at 100Mbps.

This patch adds a check to only call setup_link for fiber devices.

Reported-and-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Tested-by: Tony Luck <tony.luck@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 3bea8edd

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -8449,8 +8449,8 @@ static int ixgbe_probe(struct pci_dev pdev, const struct pci_device_id ent)

	ixgbe_dbg_adapter_init(adapter);		ixgbe_dbg_adapter_init(adapter);

	/* Need link setup for MNG FW, else wait for IXGBE_UP */		/* setup link for SFP devices with MNG FW, else wait for IXGBE_UP */
	if (ixgbe_mng_enabled(hw) && hw->mac.ops.setup_link)		if (ixgbe_mng_enabled(hw) && ixgbe_is_sfp(hw) && hw->mac.ops.setup_link)
	hw->mac.ops.setup_link(hw,		hw->mac.ops.setup_link(hw,
	IXGBE_LINK_SPEED_10GB_FULL \| IXGBE_LINK_SPEED_1GB_FULL,		IXGBE_LINK_SPEED_10GB_FULL \| IXGBE_LINK_SPEED_1GB_FULL,
	true);		true);