Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d1673905 authored by Sagi Grimberg's avatar Sagi Grimberg Committed by Doug Ledford
Browse files

IB/iser: Fix missing return status check in iser_send_data_out 



Since commit "IB/iser: Fix race between iser connection teardown..."
iser_initialize_task_headers() might fail, so we need to check that.

Fixes: 7414dde0 (IB/iser: Fix race between iser connection ...)
Signed-off-by: default avatarSagi Grimberg <sagig@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 1156cc80

drivers/infiniband/ulp/iser/iser_initiator.c

+5 −3
Original line number Diff line number Diff line
@@ -454,7 +454,7 @@ int iser_send_data_out(struct iscsi_conn *conn, 
	unsigned long buf_offset;

	unsigned long data_seg_len;

	uint32_t itt;

	int err = 0;

	int err;

	struct ib_sge *tx_dsg;



	itt = (__force uint32_t)hdr->itt;
@@ -475,7 +475,9 @@ int iser_send_data_out(struct iscsi_conn *conn, 
	memcpy(&tx_desc->iscsi_header, hdr, sizeof(struct iscsi_hdr));



	/* build the tx desc */

	iser_initialize_task_headers(task, tx_desc);

	err = iser_initialize_task_headers(task, tx_desc);

	if (err)

		goto send_data_out_error;



	mem_reg = &iser_task->rdma_reg[ISER_DIR_OUT];

	tx_dsg = &tx_desc->tx_sg[1];